feat: home display settings and section layout#7
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13c1e89f2d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR extends QuickShell’s Command Palette settings and home layout capabilities by introducing configurable “Recent workspaces” behavior and a more structured sectioned list layout (Favorites → Recent → Workspaces), alongside shared Adaptive Card JSON helpers and settings-form UX updates.
Changes:
- Add a Home display settings form with a debounced recent-count stepper, persisted via new
recentWorkspaceCountsetting. - Introduce
SectionListItems+ refactor layout rendering to emit visible section headers and enforce Favorites/Recent/Workspaces ordering. - Refactor Adaptive Card JSON helpers and shift terminal defaults to an auto-save interaction model.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates install notes and documents the new home section ordering semantics. |
| QuickShell/Services/ShortcutLayoutDisplay.cs | Refactors layout item generation into Favorites + Workspaces builders with exclusions and header emission logic. |
| QuickShell/Services/SettingsFormHelpers.cs | Adds debounced reload scheduling utilities for settings-driven UI refresh. |
| QuickShell/Services/SettingsCardJson.cs | Centralizes field fragments and adds recent-count stepper + autosave action helper. |
| QuickShell/Services/SectionListItems.cs | New helper to prepend CmdPal-visible section headers using Separator. |
| QuickShell/Services/QuickShellStatus.cs | Simplifies toast behavior to toolkit toast messages that survive form rebuilds. |
| QuickShell/Services/DiscoverGitRepoListItems.cs | Converts repo discovery output to use section-header helper. |
| QuickShell/QuickShellSettingsManager.cs | Adds persisted recent-count setting and exposes update/read APIs. |
| QuickShell/QuickShellCommandsProvider.cs | Updates reload behavior and command item resolution logic. |
| QuickShell/QuickShell.csproj | Adjusts publish profile selection and exposes internals to test assembly. |
| QuickShell/Pages/TerminalDefaultsSettingsForm.cs | Removes explicit Save button and rebuilds template/refresh flow for autosave UX. |
| QuickShell/Pages/QuickShellPage.cs | Applies new home ordering + recent-count setting to recents list generation. |
| QuickShell/Pages/QuickShellExtensionSettingsPage.cs | Caches settings forms to reduce rebuild churn and adds Home display form. |
| QuickShell/Pages/HomeDisplaySettingsForm.cs | New form implementing recent-count stepper with debounced persistence + home reload. |
| QuickShell.Core/Services/ShortcutRecents.cs | Adds maxCount parameter with normalization and hide-when-zero behavior. |
| QuickShell.Core/Services/QuickShellSettingsReader.cs | Persists and reads the new recent-count setting from settings.json. |
| QuickShell.Core/Services/QuickShellRecentSettings.cs | New shared bounds/defaults + normalization helper for recent-count setting. |
| QuickShell.Core/Services/AdaptiveCardFormJson.cs | New shared Adaptive Card field fragments (label/help/group). |
| QuickShell.Core.Tests/WorkspaceUtilityTests.cs | Adds tests for recent-count normalization, recents max-count behavior, and other related helpers. |
| QuickShell.Core.Tests/SectionListItemsTests.cs | Adds unit tests for section header emission and shortcut layout ordering behaviors. |
| QuickShell.Core.Tests/QuickShell.Core.Tests.csproj | Updates target framework and adds a reference to QuickShell for cross-assembly testing. |
Restore launch form page routing, rebuild pending-edit cards per state, use ChoiceSet changeAction for autosave, and persist recent count with invariant culture. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bcaf5eefc1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tonythethompson
force-pushed
the
pr/companion-app-discovery
branch
from
6c4f791 to
de26342
Compare
Add home page section ordering, recent workspace limits, adaptive card form helpers, and settings UI refinements. Includes Codex review fixes for form stepper actions and git repo index invalidation on reload. Co-authored-by: Cursor <cursoragent@cursor.com>
tonythethompson
force-pushed
the
pr/settings-and-home-display
branch
from
bcaf5ee to
8141c01
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
BuildFormChoicesJson now omits catalog presets that are not installed, matching IsPresetInstalled and fixing CI on runners where VS Code is on PATH but not at standard install locations. Co-authored-by: Cursor <cursoragent@cursor.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
tonythethompson
changed the base branch from
pr/companion-app-discovery
to
master
Summary
Test plan
Made with Cursor